Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/android/vr_shell/gltf_parser.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/gltf_parser.cc
diff --git a/chrome/browser/android/vr_shell/gltf_parser.cc b/chrome/browser/android/vr_shell/gltf_parser.cc
index 17be0c8c098129ba39c62fd4acb0652695d2fa89..5565215b835780886fdcceb59fc0c5170cfd838d 100644
--- a/chrome/browser/android/vr_shell/gltf_parser.cc
+++ b/chrome/browser/android/vr_shell/gltf_parser.cc
@@ -155,7 +155,7 @@ bool GltfParser::SetMeshes(const base::DictionaryValue& dict) {
if (mesh_dict->GetList("primitives", &list)) {
for (const auto& primitive_value : *list) {
const base::DictionaryValue* primitive_dict;
- if (!primitive_value->GetAsDictionary(&primitive_dict))
+ if (!primitive_value.GetAsDictionary(&primitive_dict))
return false;
auto primitive = ProcessPrimitive(*primitive_dict);
@@ -210,7 +210,7 @@ bool GltfParser::SetNodes(const base::DictionaryValue& dict) {
if (node_dict->GetList("meshes", &list)) {
std::string mesh_key;
for (const auto& mesh_value : *list) {
- if (!mesh_value->GetAsString(&mesh_key))
+ if (!mesh_value.GetAsString(&mesh_key))
return false;
auto mesh_it = mesh_ids_.find(mesh_key);
if (mesh_it == mesh_ids_.end())
@@ -233,7 +233,7 @@ bool GltfParser::SetNodes(const base::DictionaryValue& dict) {
if (node_dict->GetList("children", &list)) {
std::string node_key;
for (const auto& mesh_value : *list) {
- if (!mesh_value->GetAsString(&node_key))
+ if (!mesh_value.GetAsString(&node_key))
return false;
auto node_it = nodes.find(node_key);
if (node_it == nodes.end())
@@ -257,7 +257,7 @@ bool GltfParser::SetScenes(const base::DictionaryValue& dict) {
if (scene_dict->GetList("nodes", &list)) {
std::string node_key;
for (const auto& node_value : *list) {
- if (!node_value->GetAsString(&node_key))
+ if (!node_value.GetAsString(&node_key))
return false;
auto node_it = node_ids_.find(node_key);
if (node_it == node_ids_.end())

Powered by Google App Engine
This is Rietveld 408576698