Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: remoting/test/host_list_fetcher.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/test/host_list_fetcher.cc
diff --git a/remoting/test/host_list_fetcher.cc b/remoting/test/host_list_fetcher.cc
index a652d14c21d5ded714963097eed0c2eb01a6caa7..3eb3ee0aafa8223dd0c5e1e25e82a5f5e19410e8 100644
--- a/remoting/test/host_list_fetcher.cc
+++ b/remoting/test/host_list_fetcher.cc
@@ -87,10 +87,10 @@ bool HostListFetcher::ProcessResponse(
}
// Any host_info with malformed data will not be added to the hostlist.
- base::DictionaryValue* host_dict;
+ const base::DictionaryValue* host_dict;
for (const auto& host_info : *hosts) {
HostInfo host;
- if (host_info->GetAsDictionary(&host_dict) &&
+ if (host_info.GetAsDictionary(&host_dict) &&
host.ParseHostInfo(*host_dict)) {
hostlist->push_back(host);
}

Powered by Google App Engine
This is Rietveld 408576698