Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: extensions/common/manifest_handlers/action_handlers_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/action_handlers_handler.cc
diff --git a/extensions/common/manifest_handlers/action_handlers_handler.cc b/extensions/common/manifest_handlers/action_handlers_handler.cc
index 2d303181183a8c98030968bd029d323f6d178bcd..c5ac38d6f72d36ca34f943c014610ffe88a8ef88 100644
--- a/extensions/common/manifest_handlers/action_handlers_handler.cc
+++ b/extensions/common/manifest_handlers/action_handlers_handler.cc
@@ -42,9 +42,9 @@ bool ActionHandlersHandler::Parse(Extension* extension, base::string16* error) {
}
auto info = base::MakeUnique<ActionHandlersInfo>();
- for (const std::unique_ptr<base::Value>& wrapped_value : *entries) {
+ for (const base::Value& wrapped_value : *entries) {
std::string value;
- if (!wrapped_value->GetAsString(&value)) {
+ if (!wrapped_value.GetAsString(&value)) {
*error = base::ASCIIToUTF16(errors::kInvalidActionHandlersType);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698