extensions/browser/extension_prefs.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_prefs.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_prefs.cc

diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc

index 8d080434c5d1a93237c26eeee185c72c11ccc19d..544a4be4a5aa0a91d4cb0da86c50985208cf790a 100644

--- a/extensions/browser/extension_prefs.cc

+++ b/extensions/browser/extension_prefs.cc

@@ -1802,7 +1802,7 @@ bool ExtensionPrefs::GetUserExtensionPrefIntoContainer(

std::string extension_id;

for (base::ListValue::const_iterator value_it = user_pref_as_list->begin();

value_it != user_pref_as_list->end(); ++value_it) {

- if (!(*value_it)->GetAsString(&extension_id)) {

+ if (!value_it->GetAsString(&extension_id)) {

NOTREACHED();

continue;

}