content/browser/webrtc/webrtc_getusermedia_browsertest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/webrtc/webrtc_getusermedia_browsertest.cc

diff --git a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc b/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

index 3dfb8284870ed9c1d6c029547b0cf1b984377b66..80e4453e2c6bfb17d34b2e7c77f7ab89b313ea35 100644

--- a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

+++ b/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

@@ -245,7 +245,7 @@ class WebRtcGetUserMediaBrowserTest : public WebRtcContentBrowserTestBase {

const base::DictionaryValue* dict;

std::string kind;

std::string device_id;

- ASSERT_TRUE((*it)->GetAsDictionary(&dict));

+ ASSERT_TRUE(it->GetAsDictionary(&dict));

ASSERT_TRUE(dict->GetString("kind", &kind));

ASSERT_TRUE(dict->GetString("id", &device_id));

ASSERT_FALSE(device_id.empty());