content/browser/devtools/protocol/tracing_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tracing_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/tracing_handler.cc

diff --git a/content/browser/devtools/protocol/tracing_handler.cc b/content/browser/devtools/protocol/tracing_handler.cc

index 11a508b8297611382c0a01af415500d3926bd21d..e1ffb4d989f43fbdf20eb9248ba581757deca7be 100644

--- a/content/browser/devtools/protocol/tracing_handler.cc

+++ b/content/browser/devtools/protocol/tracing_handler.cc

@@ -63,7 +63,7 @@ std::unique_ptr<base::Value> ConvertDictKeyStyle(const base::Value& value) {

if (value.GetAsList(&list)) {

std::unique_ptr<base::ListValue> out_list(new base::ListValue());

for (const auto& value : *list)

- out_list->Append(ConvertDictKeyStyle(*value));

+ out_list->Append(ConvertDictKeyStyle(value));

return std::move(out_list);

}