Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index e6b90a7e03fdd691d85d6f7e3aea5d94b0e4ee06..32e4a9b95b1e486254bd87e99bb334450f7a3e57 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -56,12 +56,12 @@ void GinJavaMethodInvocationHelper::BuildObjectRefsFromListValue(
const base::ListValue* list;
list_value.GetAsList(&list);
for (const auto& entry : *list) {
- if (AppendObjectRef(dispatcher, *entry))
+ if (AppendObjectRef(dispatcher, entry))
continue;
- if (entry->IsType(base::Value::Type::LIST)) {
- BuildObjectRefsFromListValue(dispatcher, *entry);
- } else if (entry->IsType(base::Value::Type::DICTIONARY)) {
- BuildObjectRefsFromDictionaryValue(dispatcher, *entry);
+ if (entry.IsType(base::Value::Type::LIST)) {
+ BuildObjectRefsFromListValue(dispatcher, entry);
+ } else if (entry.IsType(base::Value::Type::DICTIONARY)) {
+ BuildObjectRefsFromDictionaryValue(dispatcher, entry);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698