components/autofill/content/browser/risk/fingerprint.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/risk/fingerprint.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/browser/risk/fingerprint.cc

diff --git a/components/autofill/content/browser/risk/fingerprint.cc b/components/autofill/content/browser/risk/fingerprint.cc

index 09041403cccfb6f7a0e404993f48044e37fe6456..d382553c87c5af57e73ffcabe7740d5b890ca743 100644

--- a/components/autofill/content/browser/risk/fingerprint.cc

+++ b/components/autofill/content/browser/risk/fingerprint.cc

@@ -86,7 +86,7 @@ void AddFontsToFingerprint(const base::ListValue& fonts,

// Each item in the list is a two-element list such that the first element

// is the font family and the second is the font name.

const base::ListValue* font_description = NULL;

- bool success = it->GetAsList(&font_description);

+ bool success = it.GetAsList(&font_description);

DCHECK(success);

std::string font_name;