chromeos/system/statistics_provider.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/system/statistics_provider.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/system/statistics_provider.cc

diff --git a/chromeos/system/statistics_provider.cc b/chromeos/system/statistics_provider.cc

index 26fb751b78f404002cd4db7393515a4b70dda4a5..de21ae6e5ecae4737e07a6d914e5015921012e27 100644

--- a/chromeos/system/statistics_provider.cc

+++ b/chromeos/system/statistics_provider.cc

@@ -115,7 +115,7 @@ bool JoinListValuesToString(const base::DictionaryValue* dictionary,

bool first = true;

for (const auto& v : *list) {

std::string value;

- if (!v->GetAsString(&value))

+ if (!v.GetAsString(&value))

return false;

if (first)