chromeos/network/shill_property_handler_unittest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/shill_property_handler_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/shill_property_handler_unittest.cc

diff --git a/chromeos/network/shill_property_handler_unittest.cc b/chromeos/network/shill_property_handler_unittest.cc

index 0778663c1135486de84bdb13f26b1e2fa30b6ceb..47e169e4e4506e4bb0c9973453ed5d62527b7721 100644

--- a/chromeos/network/shill_property_handler_unittest.cc

+++ b/chromeos/network/shill_property_handler_unittest.cc

@@ -131,7 +131,7 @@ class TestListener : public internal::ShillPropertyHandler::Listener {

for (base::ListValue::const_iterator iter = entries.begin();

iter != entries.end(); ++iter) {

std::string path;

- if ((*iter)->GetAsString(&path))

+ if (iter->GetAsString(&path))

entries_[type].push_back(path);

}