chromeos/network/onc/onc_certificate_importer_impl.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_certificate_importer_impl.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_certificate_importer_impl.cc

diff --git a/chromeos/network/onc/onc_certificate_importer_impl.cc b/chromeos/network/onc/onc_certificate_importer_impl.cc

index 0542be3a86e8f9eb73320572f8eabee580bfa6a6..d36a4e5f60847eadc70f23b065791588f138cb43 100644

--- a/chromeos/network/onc/onc_certificate_importer_impl.cc

+++ b/chromeos/network/onc/onc_certificate_importer_impl.cc

@@ -167,7 +167,7 @@ bool CertificateImporterImpl::ParseServerOrCaCertificate(

for (base::ListValue::const_iterator it = trust_list->begin();

it != trust_list->end(); ++it) {

std::string trust_type;

- if (!(*it)->GetAsString(&trust_type))

+ if (!it->GetAsString(&trust_type))

NOTREACHED();

if (trust_type == ::onc::certificate::kWeb) {