chromeos/network/network_state_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_state_handler.cc

diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc

index 7581d1e1750a7907086eca69d59011a1869874c0..aeba782ca751cfe87730c31e6c33375bf4defc5b 100644

--- a/chromeos/network/network_state_handler.cc

+++ b/chromeos/network/network_state_handler.cc

@@ -602,7 +602,7 @@ void NetworkStateHandler::UpdateManagedList(ManagedState::ManagedType type,

std::set<std::string> list_entries;

for (auto& iter : entries) {

std::string path;

- iter->GetAsString(&path);

+ iter.GetAsString(&path);

if (path.empty() || path == shill::kFlimflamServicePath) {

NET_LOG_ERROR(base::StringPrintf("Bad path in list:%d", type), path);

continue;