chromeos/network/managed_network_configuration_handler_impl.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/managed_network_configuration_handler_impl.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/managed_network_configuration_handler_impl.cc

diff --git a/chromeos/network/managed_network_configuration_handler_impl.cc b/chromeos/network/managed_network_configuration_handler_impl.cc

index c91cfdaadf292386f1a49c46e3db26bf8ef0024d..d3b45256ed2f1662c6b867371d6bbf58600721ce 100644

--- a/chromeos/network/managed_network_configuration_handler_impl.cc

+++ b/chromeos/network/managed_network_configuration_handler_impl.cc

@@ -442,8 +442,8 @@ void ManagedNetworkConfigurationHandlerImpl::SetPolicy(

for (base::ListValue::const_iterator it = network_configs_onc.begin();

it != network_configs_onc.end(); ++it) {

- base::DictionaryValue* network = NULL;

- (*it)->GetAsDictionary(&network);

+ const base::DictionaryValue* network = NULL;

+ it->GetAsDictionary(&network);

DCHECK(network);

std::string guid;