chrome/service/cloud_print/printer_job_queue_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/printer_job_queue_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/cloud_print/printer_job_queue_handler.cc

diff --git a/chrome/service/cloud_print/printer_job_queue_handler.cc b/chrome/service/cloud_print/printer_job_queue_handler.cc

index 4757bd9344a49a97fbb6905ce41c2f6c246199df..64aa593b1c18bcfc33e1d62c2055d0419485b6d9 100644

--- a/chrome/service/cloud_print/printer_job_queue_handler.cc

+++ b/chrome/service/cloud_print/printer_job_queue_handler.cc

@@ -120,7 +120,7 @@ std::vector<JobDetails> PrinterJobQueueHandler::GetJobsFromQueue(

std::vector<JobDetails> jobs_with_timeouts;

for (const auto& job_value : *job_list) {

const base::DictionaryValue* job_data = nullptr;

- if (!job_value->GetAsDictionary(&job_data))

+ if (!job_value.GetAsDictionary(&job_data))

continue;

JobDetails job_details_current = ConstructJobDetailsFromJson(*job_data);