Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/browser/ui/webui/settings/certificates_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/certificates_handler.cc
diff --git a/chrome/browser/ui/webui/settings/certificates_handler.cc b/chrome/browser/ui/webui/settings/certificates_handler.cc
index 3c9af03639374d33ebd6be234cbd53b8c627a34d..3a15e417d2a4da8d739855de9f72cb4231b6ae8c 100644
--- a/chrome/browser/ui/webui/settings/certificates_handler.cc
+++ b/chrome/browser/ui/webui/settings/certificates_handler.cc
@@ -86,15 +86,14 @@ struct DictionaryIdComparator {
explicit DictionaryIdComparator(icu::Collator* collator)
: collator_(collator) {}
- bool operator()(const std::unique_ptr<base::Value>& a,
- const std::unique_ptr<base::Value>& b) const {
- DCHECK(a->GetType() == base::Value::Type::DICTIONARY);
- DCHECK(b->GetType() == base::Value::Type::DICTIONARY);
+ bool operator()(const base::Value& a, const base::Value& b) const {
+ DCHECK(a.GetType() == base::Value::Type::DICTIONARY);
+ DCHECK(b.GetType() == base::Value::Type::DICTIONARY);
const base::DictionaryValue* a_dict;
- bool a_is_dictionary = a->GetAsDictionary(&a_dict);
+ bool a_is_dictionary = a.GetAsDictionary(&a_dict);
DCHECK(a_is_dictionary);
const base::DictionaryValue* b_dict;
- bool b_is_dictionary = b->GetAsDictionary(&b_dict);
+ bool b_is_dictionary = b.GetAsDictionary(&b_dict);
DCHECK(b_is_dictionary);
base::string16 a_str;
base::string16 b_str;

Powered by Google App Engine
This is Rietveld 408576698