Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3316)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 491cb0b196770e809de1d4ad1d6fa0c3ae2a53fb..0130d7fa6bbc03ba3f4924fb98c62e632c1bfd73 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -941,8 +941,8 @@ void ContentSettingsHandler::CompareMediaExceptionsWithFlash(
settings.exceptions.clear();
for (base::ListValue::const_iterator entry = exceptions.begin();
entry != exceptions.end(); ++entry) {
- base::DictionaryValue* dict = nullptr;
- bool valid_dict = (*entry)->GetAsDictionary(&dict);
+ const base::DictionaryValue* dict = nullptr;
+ bool valid_dict = entry->GetAsDictionary(&dict);
DCHECK(valid_dict);
std::string origin;

Powered by Google App Engine
This is Rietveld 408576698