chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/browser/spellchecker/spellcheck_service_browsertest.cc ('k') | chrome/browser/supervised_user/supervised_user_site_list.cc » ('j') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc

diff --git a/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc b/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc

index 28fbabb71b72bf3bb45ba1ac74d4d877eddb97f4..4fef00e7bb44f2819f5c72cb79a70cfece6f7f1e 100644

--- a/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc

+++ b/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc

@@ -239,8 +239,8 @@ bool FamilyInfoFetcher::ParseMembers(const base::ListValue* list,

it != list->end();

it++) {

FamilyMember member;

- base::DictionaryValue* dict = NULL;

- if (!(*it)->GetAsDictionary(&dict) || !ParseMember(dict, &member)) {

+ const base::DictionaryValue* dict = NULL;

+ if (!it->GetAsDictionary(&dict) || !ParseMember(dict, &member)) {

return false;

}

members->push_back(member);