chrome/browser/spellchecker/spellcheck_service_browsertest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

index 13deefa92cf75258fb5c63653c6f5f87228c98dc..3affcf216a99041d4851c7111c1d8033c3434253 100644

--- a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

+++ b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

@@ -132,7 +132,7 @@ class SpellcheckServiceBrowserTest : public InProcessBrowserTest {

std::vector<std::string> dictionaries;

for (const auto& item_value : *list_value) {

std::string dictionary;

- EXPECT_TRUE(item_value->GetAsString(&dictionary));

+ EXPECT_TRUE(item_value.GetAsString(&dictionary));

dictionaries.push_back(dictionary);

}

return base::JoinString(dictionaries, ",");