Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3574)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc ('k') | chrome/browser/profile_resetter/profile_resetter_unittest.cc » ('j') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/cloud_print/cloud_print_printer_list.cc
diff --git a/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc b/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc
index 19537782ad0cfeee1ee30a6f60a74743d04a1983..339c088f320ac9ebf3b1cf48e654d2a56f4ce303 100644
--- a/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc
+++ b/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc
@@ -42,10 +42,10 @@ void CloudPrintPrinterList::OnGCDApiFlowComplete(
for (base::ListValue::const_iterator i = printers->begin();
i != printers->end();
i++) {
- base::DictionaryValue* printer;
+ const base::DictionaryValue* printer;
Device printer_details;
- if (!(*i)->GetAsDictionary(&printer))
+ if (!i->GetAsDictionary(&printer))
continue;
if (!FillPrinterDetails(*printer, &printer_details))
« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc ('k') | chrome/browser/profile_resetter/profile_resetter_unittest.cc » ('j') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698