Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/cloud_print/cloud_print_printer_list.h" 5 #include "chrome/browser/printing/cloud_print/cloud_print_printer_list.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "chrome/common/cloud_print/cloud_print_constants.h" 9 #include "chrome/common/cloud_print/cloud_print_constants.h"
10 #include "components/cloud_devices/common/cloud_devices_urls.h" 10 #include "components/cloud_devices/common/cloud_devices_urls.h"
(...skipping 24 matching lines...) Expand all
35 35
36 if (!value.GetList(cloud_print::kPrinterListValue, &printers)) { 36 if (!value.GetList(cloud_print::kPrinterListValue, &printers)) {
37 delegate_->OnDeviceListUnavailable(); 37 delegate_->OnDeviceListUnavailable();
38 return; 38 return;
39 } 39 }
40 40
41 DeviceList devices; 41 DeviceList devices;
42 for (base::ListValue::const_iterator i = printers->begin(); 42 for (base::ListValue::const_iterator i = printers->begin();
43 i != printers->end(); 43 i != printers->end();
44 i++) { 44 i++) {
45 base::DictionaryValue* printer; 45 const base::DictionaryValue* printer;
46 Device printer_details; 46 Device printer_details;
47 47
48 if (!(*i)->GetAsDictionary(&printer)) 48 if (!i->GetAsDictionary(&printer))
49 continue; 49 continue;
50 50
51 if (!FillPrinterDetails(*printer, &printer_details)) 51 if (!FillPrinterDetails(*printer, &printer_details))
52 continue; 52 continue;
53 53
54 devices.push_back(printer_details); 54 devices.push_back(printer_details);
55 } 55 }
56 56
57 delegate_->OnDeviceListReady(devices); 57 delegate_->OnDeviceListReady(devices);
58 } 58 }
(...skipping 14 matching lines...) Expand all
73 } 73 }
74 74
75 // Non-essential. 75 // Non-essential.
76 printer_value.GetString(cloud_print::kPrinterDescValue, 76 printer_value.GetString(cloud_print::kPrinterDescValue,
77 &printer_details->description); 77 &printer_details->description);
78 78
79 return true; 79 return true;
80 } 80 }
81 81
82 } // namespace cloud_print 82 } // namespace cloud_print
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698