chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

diff --git a/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc b/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

index 50547cffee6a0b62f2d3c8f7fb1f7808147d351f..876bce1476ef161fc310653e18b96514ef3104bb 100644

--- a/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

+++ b/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

@@ -57,7 +57,7 @@ class TestCommandLinePrefStore : public ChromeCommandLinePrefStore {

std::string cipher_string;

for (base::ListValue::const_iterator it = list_value->begin();

it != list_value->end(); ++it, ++ciphers) {

- ASSERT_TRUE((*it)->GetAsString(&cipher_string));

+ ASSERT_TRUE(it->GetAsString(&cipher_string));

EXPECT_EQ(*ciphers, cipher_string);

}