chrome/browser/extensions/webstore_inline_installer_browsertest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

diff --git a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

index 555ef2fd530f0a793edc4b7945e4c0c9640bc803..7c3702f5e388b9efd7d70c388dd9dae2df49bc23 100644

--- a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

+++ b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

@@ -434,7 +434,7 @@ IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerRedirectTest,

int i = 0;

for (const auto& value : *redirect_list) {

std::string value_string;

- ASSERT_TRUE(value->GetAsString(&value_string));

+ ASSERT_TRUE(value.GetAsString(&value_string));

GURL redirect_url(value_string);

EXPECT_EQ(expected_redirect_domains[i++], redirect_url.host());

}