chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/browser/extensions/webstore_inline_installer_browsertest.cc ('k') | chrome/browser/media/webrtc/media_permission.cc » ('j') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

diff --git a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

index 80acaac6e8ac13fd284f1971055ca99dac74122a..92646ecce53f235d0dfcd1a0b0bc1a762c46c1a6 100644

--- a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

+++ b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

@@ -168,7 +168,7 @@ void ChromeInternalLogSource::PopulateSyncLogs(SystemLogsResponse* response) {

for (base::ListValue::iterator it = details->begin();

it != details->end(); ++it) {

base::DictionaryValue* dict = NULL;

- if ((*it)->GetAsDictionary(&dict)) {

+ if (it->GetAsDictionary(&dict)) {

std::string title;

dict->GetString("title", &title);

if (title == syncer::sync_ui_util::kIdentityTitle) {