Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4172)

Unified Diff: chrome/browser/extensions/extension_override_apitest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_override_apitest.cc
diff --git a/chrome/browser/extensions/extension_override_apitest.cc b/chrome/browser/extensions/extension_override_apitest.cc
index ad91455c2af1b38c51521120f5220ade2b2762f7..6da507d43fdcd70a24a90612039208161760f053 100644
--- a/chrome/browser/extensions/extension_override_apitest.cc
+++ b/chrome/browser/extensions/extension_override_apitest.cc
@@ -42,7 +42,7 @@ class ExtensionOverrideTest : public ExtensionApiTest {
for (const auto& val : *values) {
const base::DictionaryValue* dict = nullptr;
std::string entry;
- if (!val->GetAsDictionary(&dict) || !dict->GetString("entry", &entry) ||
+ if (!val.GetAsDictionary(&dict) || !dict->GetString("entry", &entry) ||
seen_overrides.count(entry) != 0)
return false;
seen_overrides.insert(entry);

Powered by Google App Engine
This is Rietveld 408576698