Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4740)

Unified Diff: chrome/browser/extensions/extension_management.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management.cc
diff --git a/chrome/browser/extensions/extension_management.cc b/chrome/browser/extensions/extension_management.cc
index 202f84c8ec6e290fe4e10a4c4e12cb8fa7625565..f4333d3cb95d9534d4ac053f9dcfa073d0e53d5e 100644
--- a/chrome/browser/extensions/extension_management.cc
+++ b/chrome/browser/extensions/extension_management.cc
@@ -299,7 +299,7 @@ void ExtensionManagement::Refresh() {
if (allowed_list_pref) {
for (base::ListValue::const_iterator it = allowed_list_pref->begin();
it != allowed_list_pref->end(); ++it) {
- if ((*it)->GetAsString(&id) && crx_file::id_util::IdIsValid(id))
+ if (it->GetAsString(&id) && crx_file::id_util::IdIsValid(id))
AccessById(id)->installation_mode = INSTALLATION_ALLOWED;
}
}
@@ -307,7 +307,7 @@ void ExtensionManagement::Refresh() {
if (denied_list_pref) {
for (base::ListValue::const_iterator it = denied_list_pref->begin();
it != denied_list_pref->end(); ++it) {
- if ((*it)->GetAsString(&id) && crx_file::id_util::IdIsValid(id))
+ if (it->GetAsString(&id) && crx_file::id_util::IdIsValid(id))
AccessById(id)->installation_mode = INSTALLATION_BLOCKED;
}
}
@@ -320,7 +320,7 @@ void ExtensionManagement::Refresh() {
for (base::ListValue::const_iterator it = install_sources_pref->begin();
it != install_sources_pref->end(); ++it) {
std::string url_pattern;
- if ((*it)->GetAsString(&url_pattern)) {
+ if (it->GetAsString(&url_pattern)) {
URLPattern entry(URLPattern::SCHEME_ALL);
if (entry.Parse(url_pattern) == URLPattern::PARSE_SUCCESS) {
global_settings_->install_sources.AddPattern(entry);
@@ -339,11 +339,11 @@ void ExtensionManagement::Refresh() {
it != allowed_types_pref->end(); ++it) {
int int_value;
std::string string_value;
- if ((*it)->GetAsInteger(&int_value) && int_value >= 0 &&
+ if (it->GetAsInteger(&int_value) && int_value >= 0 &&
int_value < Manifest::Type::NUM_LOAD_TYPES) {
global_settings_->allowed_types.push_back(
static_cast<Manifest::Type>(int_value));
- } else if ((*it)->GetAsString(&string_value)) {
+ } else if (it->GetAsString(&string_value)) {
Manifest::Type manifest_type =
schema_constants::GetManifestType(string_value);
if (manifest_type != Manifest::TYPE_UNKNOWN)

Powered by Google App Engine
This is Rietveld 408576698