chrome/browser/android/bookmarks/partner_bookmarks_shim.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc b/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

index 6b5a706d777f6873c24f9f25518ec8f2341c690a..bd15315a24d0f70f16b61749fd1173554ef3132f 100644

--- a/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

+++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

@@ -253,7 +253,7 @@ void PartnerBookmarksShim::ReloadNodeMapping() {

for (base::ListValue::const_iterator it = list->begin();

it != list->end(); ++it) {

const base::DictionaryValue* dict = NULL;

- if (!*it || !(*it)->GetAsDictionary(&dict)) {

+ if (!it->GetAsDictionary(&dict)) {

NOTREACHED();

continue;

}