Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
 
 #include <tuple>
 
 #include "base/lazy_instance.h"
 #include "base/values.h"
@@ skipping 235 matching lines @@
     return;
 
   const base::ListValue* list =
       prefs_->GetList(prefs::kPartnerBookmarkMappings);
   if (!list)
     return;
 
   for (base::ListValue::const_iterator it = list->begin();
        it != list->end(); ++it) {
     const base::DictionaryValue* dict = NULL;
-    if (!*it || !(*it)->GetAsDictionary(&dict)) {
+    if (!it->GetAsDictionary(&dict)) {
       NOTREACHED();
       continue;
     }
 
     std::string url;
     base::string16 provider_title;
     base::string16 mapped_title;
     if (!dict->GetString(kMappingUrl, &url) ||
         !dict->GetString(kMappingProviderTitle, &provider_title) ||
         !dict->GetString(kMappingTitle, &mapped_title)) {
@@ skipping 16 matching lines @@
        i != node_rename_remove_map_.end();
        ++i) {
     base::DictionaryValue* dict = new base::DictionaryValue();
     dict->SetString(kMappingUrl, i->first.url().spec());
     dict->SetString(kMappingProviderTitle, i->first.provider_title());
     dict->SetString(kMappingTitle, i->second);
     list.Append(dict);
   }
   prefs_->Set(prefs::kPartnerBookmarkMappings, list);
 }