Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2740133004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, martijn+crwatch_martijnc.be, Eran Messeri
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=eranm@chromium.org Review-Url: https://codereview.chromium.org/2740133004 Cr-Commit-Position: refs/heads/master@{#456143} Committed: https://chromium.googlesource.com/chromium/src/+/04ab58bf5dc99328860c1f3f3b46862bb628b0df

Patch Set 1 #

Total comments: 4

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/certificate_transparency/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/packed_ct_ev_whitelist/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 19:12:30 UTC) #3
Ryan Sleevi
Suggestions below, LGTM % fixing :) https://codereview.chromium.org/2740133004/diff/1/components/certificate_transparency/OWNERS File components/certificate_transparency/OWNERS (right): https://codereview.chromium.org/2740133004/diff/1/components/certificate_transparency/OWNERS#newcode5 components/certificate_transparency/OWNERS:5: # COMPONENT: Internals>Network ...
3 years, 9 months ago (2017-03-10 19:17:33 UTC) #4
ymzhang1
On 2017/03/10 19:17:33, Ryan Sleevi wrote: > Suggestions below, LGTM % fixing :) > > ...
3 years, 9 months ago (2017-03-10 19:22:56 UTC) #5
Ryan Sleevi
On 2017/03/10 19:22:56, ymzhang1 wrote: > Thanks for the quick reply! One question about team. ...
3 years, 9 months ago (2017-03-10 19:23:44 UTC) #6
ymzhang1
https://codereview.chromium.org/2740133004/diff/1/components/certificate_transparency/OWNERS File components/certificate_transparency/OWNERS (right): https://codereview.chromium.org/2740133004/diff/1/components/certificate_transparency/OWNERS#newcode5 components/certificate_transparency/OWNERS:5: # COMPONENT: Internals>Network On 2017/03/10 19:17:33, Ryan Sleevi wrote: ...
3 years, 9 months ago (2017-03-10 19:27:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740133004/20001
3 years, 9 months ago (2017-03-10 19:28:29 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 20:05:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/04ab58bf5dc99328860c1f3f3b46...

Powered by Google App Engine
This is Rietveld 408576698