Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2740133003: Fix Windows compile error with cherry-pick. (Closed)

Created:
3 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix Windows compile error with cherry-pick. M57 branch had desktop-specific RenderWidgetInputHandlerDelegate derived class apparently not present on ToT, causing http://crrev.com/2736413002 to break compile. Switch to an empty default implementation to cover it. BUG=700133, 650204, 699699 Review-Url: https://codereview.chromium.org/2740133003 . Cr-Commit-Position: refs/branch-heads/2987@{#808} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ec5e87b1835fd460bc175897024a44f567b32e22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/input/render_widget_input_handler_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 9 months ago (2017-03-09 20:47:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec5e87b1835fd460bc175897024a44f567b32e22.

Powered by Google App Engine
This is Rietveld 408576698