Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2740123003: Include "public" source files in generated Xcode project. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include "public" source files in generated Xcode project. Targets can restrict the list of public headers by using "public" property in addition to "sources". Include them in the generated Xcode project as any other source file. BUG=None Review-Url: https://codereview.chromium.org/2740123003 Cr-Commit-Position: refs/heads/master@{#456339} Committed: https://chromium.googlesource.com/chromium/src/+/5d93a97915ac8492667e3fbedfc26f606e1d1099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/gn/xcode_writer.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sdefresne
Please take a look. This was reported on gn-dev [1] but no bug was created. ...
3 years, 9 months ago (2017-03-09 17:50:08 UTC) #4
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-09 18:57:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740123003/1
3 years, 9 months ago (2017-03-13 08:36:23 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 08:48:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d93a97915ac8492667e3fbedfc2...

Powered by Google App Engine
This is Rietveld 408576698