content/public/android/java/src/org/chromium/content/browser/SelectionClient.java - Issue 2740103006: Implement SmartText selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

Issue 2740103006: Implement SmartText selection. (Closed)

Patch Set: Made ~ContextSelectionClient() public and inlined SelectionPopupControler.unhideActionMode() Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java ('k') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

index 041cdcf4b53d8f62c3ec69b40308cd26a1a1b938..7c9a844914f480ab7af0c7bab822fedf82dbb7e1 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

@@ -28,4 +28,11 @@ public interface SelectionClient {

* @param y The y coordinate of the tap.

void showUnhandledTapUIIfNeeded(int x, int y);

+ /**

+ * Returns true if the SelectionClient sends responces that can contain information about

+ * the context menu (e.g. that we need a new menu item). In this case an embedder might want

+ * to wait for this responce before taking further actions.

+ */

+ boolean sendsSelectionPopupUpdates();

}