content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java - Issue 2740103006: Implement SmartText selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java

Issue 2740103006: Implement SmartText selection. (Closed)

Patch Set: Made ~ContextSelectionClient() public and inlined SelectionPopupControler.unhideActionMode() Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java ('k') | content/public/android/java/src/org/chromium/content/browser/SelectionClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java b/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java

index 6f00e798e7956b7e009b9890bc6dcdae583d8668..50890fea3708421a69ca6f40837a9a7fa6ee0848 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java

@@ -50,6 +50,14 @@ public interface ContextSelectionProvider {

* OnClickListener for the suggested menu item.

public OnClickListener onClickListener;

+ /**

+ * A helper method that returns true if the result has both visual info

+ * and an action so that, for instance, one can make a new menu item.

+ */

+ public boolean hasNamedAction() {

+ return (label != null || icon != null) && (intent != null || onClickListener != null);

+ }

}

/**