Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

Issue 2740103006: Implement SmartText selection. (Closed)
Patch Set: Addressed some comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java
index 041cdcf4b53d8f62c3ec69b40308cd26a1a1b938..962be9fbdd35bec7460135ea0e6a616073bc07aa 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java
@@ -28,4 +28,12 @@ public interface SelectionClient {
* @param y The y coordinate of the tap.
*/
void showUnhandledTapUIIfNeeded(int x, int y);
+
+ /**
+ * Returns true if the SelectionClient can send information
Ted C 2017/03/20 20:35:50 in java, you should wrap at 100 chars for comments
Tima Vaisburd 2017/03/21 02:07:02 Done.
+ * that can affect the content of the context menu (e.g. add
+ * a new menu item). In this case an embedder might want to
+ * wait for this info before taking further actions.
+ */
+ boolean sendsMenuUpdates();
Ted C 2017/03/20 20:35:50 what menu is this referring to? Is this the actio
Tima Vaisburd 2017/03/21 02:07:02 I found my explanation confusing and rewrote it. I
}

Powered by Google App Engine
This is Rietveld 408576698