Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

Issue 2740103006: Implement SmartText selection. (Closed)
Patch Set: Addressed some comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 /** 7 /**
8 * Interface to a content layer client that can process and modify selection tex t. 8 * Interface to a content layer client that can process and modify selection tex t.
9 */ 9 */
10 public interface SelectionClient { 10 public interface SelectionClient {
(...skipping 10 matching lines...) Expand all
21 * @param posYPix The y coordinate of the selection start handle. 21 * @param posYPix The y coordinate of the selection start handle.
22 */ 22 */
23 void onSelectionEvent(int eventType, float posXPix, float posYPix); 23 void onSelectionEvent(int eventType, float posXPix, float posYPix);
24 24
25 /** 25 /**
26 * Requests to show the UI for an unhandled tap, if needed. 26 * Requests to show the UI for an unhandled tap, if needed.
27 * @param x The x coordinate of the tap. 27 * @param x The x coordinate of the tap.
28 * @param y The y coordinate of the tap. 28 * @param y The y coordinate of the tap.
29 */ 29 */
30 void showUnhandledTapUIIfNeeded(int x, int y); 30 void showUnhandledTapUIIfNeeded(int x, int y);
31
32 /**
33 * Returns true if the SelectionClient can send information
Ted C 2017/03/20 20:35:50 in java, you should wrap at 100 chars for comments
Tima Vaisburd 2017/03/21 02:07:02 Done.
34 * that can affect the content of the context menu (e.g. add
35 * a new menu item). In this case an embedder might want to
36 * wait for this info before taking further actions.
37 */
38 boolean sendsMenuUpdates();
Ted C 2017/03/20 20:35:50 what menu is this referring to? Is this the actio
Tima Vaisburd 2017/03/21 02:07:02 I found my explanation confusing and rewrote it. I
31 } 39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698