Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2740073002: [json] use OrderedHashSet for replacer property list. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] use OrderedHashSet for replacer property list. R=ishell@chromium.org BUG=v8:6071 Review-Url: https://codereview.chromium.org/2740073002 Cr-Commit-Position: refs/heads/master@{#43690} Committed: https://chromium.googlesource.com/v8/v8/+/f2408624c91d7f6a717256d49788825965237412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M src/json-stringifier.cc View 3 chunks +6 lines, -15 lines 0 comments Download
M test/mjsunit/json.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-09 08:38:59 UTC) #1
Igor Sheludko
lgtm
3 years, 9 months ago (2017-03-09 09:41:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740073002/1
3 years, 9 months ago (2017-03-09 09:45:59 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 12:27:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f2408624c91d7f6a717256d497888259652...

Powered by Google App Engine
This is Rietveld 408576698