Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2740063003: Revert of [table] Stretching tables when needed due to self-alignment properties (Closed)

Created:
3 years, 9 months ago by jfernandez
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, svillar, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [table] Stretching tables when needed due to self-alignment properties (patchset #6 id:120001 of https://codereview.chromium.org/2528253003/ ) Reason for revert: This patch is causing several important regressions. Original issue's description: > [table] Stretching tables when needed due to self-alignment properties > > The Self-Alignment properties, align-self and justify-self, apply to > tables when they are flex or grid items. > > This patch addresses only the issue of applying the stretch value, which > effectively affects the size of the table in those cases. > > The justify-self applies also to tables when they are block-level > boxes, but the alignment feature is still not implemented for that > case, so for now the related test cases expect no stretching. > > Other values of alignment aren't implemented yet for tables, but those > will be part of future CLs, once somebody files the appropriated bug. > > BUG=667785 > > Review-Url: https://codereview.chromium.org/2528253003 > Cr-Commit-Position: refs/heads/master@{#454743} > Committed: https://chromium.googlesource.com/chromium/src/+/a90dba1f2dd094e51229dd2e5e059c6b53cee93a TBR=svillar@igalia.com,rego@igalia.com,cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=667785 Review-Url: https://codereview.chromium.org/2740063003 Cr-Commit-Position: refs/heads/master@{#455719} Committed: https://chromium.googlesource.com/chromium/src/+/772559ed7f79de8395dfb24eae582172a1840655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -172 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/flexitem-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/table-size-must-consider-stretch-alignment.html View 1 chunk +0 lines, -142 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 2 chunks +16 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jfernandez
Created Revert of [table] Stretching tables when needed due to self-alignment properties
3 years, 9 months ago (2017-03-09 09:31:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740063003/1
3 years, 9 months ago (2017-03-09 09:32:01 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 11:27:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/772559ed7f79de8395dfb24eae58...

Powered by Google App Engine
This is Rietveld 408576698