Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2740053002: DevTools: keep selected tab as persistence binding comes in (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: keep selected tab as persistence binding comes in This patch fixes a bug in the TabbedEditorContainer's handler for persistence binding. As the binding comes in, we should retain selected tab no matter what. R=dgozman Review-Url: https://codereview.chromium.org/2740053002 Cr-Commit-Position: refs/heads/master@{#456162} Committed: https://chromium.googlesource.com/chromium/src/+/d9ab107ef6724e5fe194e6b7402086d41c187063

Patch Set 1 #

Patch Set 2 : thoughtful code #

Total comments: 1

Messages

Total messages: 16 (10 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-09 08:10:19 UTC) #1
lushnikov
please, take another look!
3 years, 9 months ago (2017-03-10 19:16:39 UTC) #6
dgozman
https://codereview.chromium.org/2740053002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js File third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js (right): https://codereview.chromium.org/2740053002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js#newcode94 third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:94: if (!fileSystemTabId) { Do we have to move filsystem ...
3 years, 9 months ago (2017-03-10 19:23:38 UTC) #9
dgozman
lgtm
3 years, 9 months ago (2017-03-10 19:57:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740053002/20001
3 years, 9 months ago (2017-03-10 20:07:38 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:13:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9ab107ef6724e5fe194e6b74020...

Powered by Google App Engine
This is Rietveld 408576698