[serializer] complete slack tracking when creating context snapshot.

[serializer] complete slack tracking when creating context snapshot.

R=verwaest@chromium.org
BUG=v8:6071
Review-Url: https://codereview.chromium.org/2740033002
Cr-Commit-Position: refs/heads/master@{#43823}
Committed: https://chromium.googlesource.com/v8/v8/+/b7b2975ee119993e9a6cedbdd795ba02e6c02b10

[Yang, 2017-03-10 06:29:56]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 06:30:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 07:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 07:04:40]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-13 06:34:10]

On 2017/03/09 07:51:01, Yang wrote:

ping

[Yang, 2017-03-15 05:53:14]

On 2017/03/13 06:34:10, Yang wrote:
> On 2017/03/09 07:51:01, Yang wrote:
> 
> ping

ping

[Toon Verwaest, 2017-03-15 10:03:34]

lgtm, as it's a step forward, but this will leave unnecessary fillers in the
snapshot... might want to add a todo somewhere about that.

[Yang, 2017-03-15 10:50:07]

On 2017/03/15 10:03:34, Toon Verwaest wrote:
> lgtm, as it's a step forward, but this will leave unnecessary fillers in the
> snapshot... might want to add a todo somewhere about that.

Decided not to land this CL. In-object slack tracking is disabled when creating
a snapshot, which is why we are being conservative when estimating the number of
properties.

[Yang, 2017-03-15 11:48:48]

Description was changed from

==========
[serializer] complete slack tracking when creating context snapshot.

R=verwaest@chromium.org
BUG=v8:6071
==========

to

==========
[serializer] complete slack tracking when creating context snapshot.

R=verwaest@chromium.org
BUG=v8:6071
==========

[Yang, 2017-03-15 12:00:00]

New version as discussed. Please take a look.

[Toon Verwaest, 2017-03-15 12:20:09]

lgtm, thanks

https://codereview.chromium.org/2740033002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2740033002/diff/60001/src/objects.cc#newcode1...
src/objects.cc:13635: Isolate* isolate = GetIsolate();
unused variable?

[Yang, 2017-03-15 12:21:49]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-03-15 12:21:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2740033002/#ps80001
(title: "remove unused variable.")

[commit-bot: I haz the power, 2017-03-15 12:22:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-03-15 12:22:05]

On 2017/03/15 12:20:09, Toon Verwaest wrote:
> lgtm, thanks
> 
> https://codereview.chromium.org/2740033002/diff/60001/src/objects.cc
> File src/objects.cc (right):
> 
>
https://codereview.chromium.org/2740033002/diff/60001/src/objects.cc#newcode1...
> src/objects.cc:13635: Isolate* isolate = GetIsolate();
> unused variable?

Removed. Thanks.

[commit-bot: I haz the power, 2017-03-15 12:44:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489580509818110,
"parent_rev": "bb927eb439ee62f07df432726e0094a3dbaff73f", "commit_rev":
"b7b2975ee119993e9a6cedbdd795ba02e6c02b10"}

[commit-bot: I haz the power, 2017-03-15 12:44:52]

Description was changed from

==========
[serializer] complete slack tracking when creating context snapshot.

R=verwaest@chromium.org
BUG=v8:6071
==========

to

==========
[serializer] complete slack tracking when creating context snapshot.

R=verwaest@chromium.org
BUG=v8:6071

Review-Url: https://codereview.chromium.org/2740033002
Cr-Commit-Position: refs/heads/master@{#43823}
Committed:
https://chromium.googlesource.com/v8/v8/+/b7b2975ee119993e9a6cedbdd795ba02e6c...
==========

[commit-bot: I haz the power, 2017-03-15 12:44:53]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/b7b2975ee119993e9a6cedbdd795ba02e6c...