Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2740003003: Use IdTargetObserver in SVGFEImageElement (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IdTargetObserver in SVGFEImageElement Change SVGFEImageElement to use the observeTarget() helper from SVGURIReference. A slight change in behavior for when a load is initiated for a potential image resource is made. Instead of using a "failed element lookup and a non-existing id" as the condition, use "failed element lookup and non- local resource reference". Also add a new method clearImageResource() and put the tear-down for the image resource, and change a use of ownerDocument() to just document(). BUG=661598 Review-Url: https://codereview.chromium.org/2740003003 Cr-Commit-Position: refs/heads/master@{#455765} Committed: https://chromium.googlesource.com/chromium/src/+/32a58c7e9cf5f455eb07420587efec657b1409ba

Patch Set 1 #

Patch Set 2 : Forward declare ImageResourceContent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/Source/core/svg/SVGFEImageElement.h View 1 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp View 1 3 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-09 14:54:59 UTC) #6
Stephen Chennney
lgtm
3 years, 9 months ago (2017-03-09 15:38:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740003003/20001
3 years, 9 months ago (2017-03-09 16:27:41 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:39:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/32a58c7e9cf5f455eb07420587ef...

Powered by Google App Engine
This is Rietveld 408576698