Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: Source/bindings/v8/custom/V8WindowCustom.cpp

Issue 27400003: Get rid of custom code for Window.location attribute setter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Keep attribute Replaceable Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/core/frame/Window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8WindowCustom.cpp
diff --git a/Source/bindings/v8/custom/V8WindowCustom.cpp b/Source/bindings/v8/custom/V8WindowCustom.cpp
index 6fd8a321fa853218ba6dd72266192b325451b0ed..2386e395499ca9308dc662fab42d5295180f0421 100644
--- a/Source/bindings/v8/custom/V8WindowCustom.cpp
+++ b/Source/bindings/v8/custom/V8WindowCustom.cpp
@@ -59,7 +59,6 @@
#include "core/frame/DOMWindowTimers.h"
#include "core/frame/Frame.h"
#include "core/frame/FrameView.h"
-#include "core/frame/Location.h"
#include "core/page/Page.h"
#include "core/page/Settings.h"
#include "core/page/WindowFeatures.h"
@@ -201,16 +200,6 @@ void V8Window::eventAttributeSetterCustom(v8::Local<v8::String> name, v8::Local<
context->Global()->SetHiddenValue(eventSymbol, value);
}
-void V8Window::locationAttributeSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
-{
- DOMWindow* imp = V8Window::toNative(info.Holder());
-
- if (Location* location = imp->location()) {
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, href, value);
- location->setHref(activeDOMWindow(), firstDOMWindow(), href);
- }
-}
-
void V8Window::openerAttributeSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
{
DOMWindow* imp = V8Window::toNative(info.Holder());
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/core/frame/Window.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698