Add ShapeResult::positionForOffset method

Add ShapeResult::positionForOffset method

Add a new positionForOffset method to ShapeResult that returns the x-pos
for a given offset. Effectively being the companion to offsetForPosition
that returns the offset for a given x-pos. Also add unit tests for both.

Will be used by the LayoutNG shaper-driven line-breaking implementation.

R=kojii@chromium.org
TEST=Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp

Review-Url: https://codereview.chromium.org/2739993002
Cr-Commit-Position: refs/heads/master@{#455691}
Committed: https://chromium.googlesource.com/chromium/src/+/fde2d61151443bbd9679ab97985004ff4d29ed03

[eae, 2017-03-09 05:09:25]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 05:09:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-03-09 05:14:20]

Description was changed from

==========
shape offset w/tests

BUG=
==========

to

==========
Add ShapeResult::positionForOffset method

Add a new positionForOffset method to ShapeResult that returns the x-pos
for a given offset. Effectively being the companion to offsetForPosition
that returns the offset for a given x-pos. Also add unit tests for both.

Will be used by the LayoutNG shaper-driven line-breaking implementation.

R=kojii@chromium.org
TEST=Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
==========

[eae, 2017-03-09 05:14:20]

eae@chromium.org changed reviewers:
+ kojii@chromium.org

[eae, 2017-03-09 05:16:32]

https://codereview.chromium.org/2739993002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp (right):

https://codereview.chromium.org/2739993002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp:224: float
ShapeResult::positionForOffset(unsigned absoluteOffset) const {
This is similar to how ShapeResultBuffer::getCharacterRange but only iterates
over a single ShapeResult and only uses one offset. Once we have this a number
of callers to getCharacterRange can use this simpler and faster method instead.
It should also allow us to remove one of the two versions of the
getCharacterRange method.

[kojii, 2017-03-09 05:23:06]

lgtm, great!

[commit-bot: I haz the power, 2017-03-09 07:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 07:01:14]

Dry run: This issue passed the CQ dry run.

[eae, 2017-03-09 07:14:48]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-03-09 07:15:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 07:28:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489043688214160, "parent_rev":
"13c620a0df3f13dfb9f43c92faf2b608e0c63215", "commit_rev":
"fde2d61151443bbd9679ab97985004ff4d29ed03"}

[commit-bot: I haz the power, 2017-03-09 07:29:59]

Description was changed from

==========
Add ShapeResult::positionForOffset method

Add a new positionForOffset method to ShapeResult that returns the x-pos
for a given offset. Effectively being the companion to offsetForPosition
that returns the offset for a given x-pos. Also add unit tests for both.

Will be used by the LayoutNG shaper-driven line-breaking implementation.

R=kojii@chromium.org
TEST=Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
==========

to

==========
Add ShapeResult::positionForOffset method

Add a new positionForOffset method to ShapeResult that returns the x-pos
for a given offset. Effectively being the companion to offsetForPosition
that returns the offset for a given x-pos. Also add unit tests for both.

Will be used by the LayoutNG shaper-driven line-breaking implementation.

R=kojii@chromium.org
TEST=Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp

Review-Url: https://codereview.chromium.org/2739993002
Cr-Commit-Position: refs/heads/master@{#455691}
Committed:
https://chromium.googlesource.com/chromium/src/+/fde2d61151443bbd9679ab979850...
==========

[commit-bot: I haz the power, 2017-03-09 07:30:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fde2d61151443bbd9679ab979850...