Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2739943004: Disable testSavingToReadingList on iPad. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
Reviewers:
gambard, msarda
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testSavingToReadingList on iPad. This test is failing on all downstream iPad versions. BUG=700001 TBR=gambard Review-Url: https://codereview.chromium.org/2739943004 Cr-Commit-Position: refs/heads/master@{#455773} Committed: https://chromium.googlesource.com/chromium/src/+/6747fd8bad7c49ddcf8754d45fa0416e10a4441b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_egtest.mm View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
msarda
lgtm
3 years, 9 months ago (2017-03-09 15:25:01 UTC) #2
baxley
+tbr=gambard for OWNERS
3 years, 9 months ago (2017-03-09 15:32:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739943004/1
3 years, 9 months ago (2017-03-09 15:32:47 UTC) #7
gambard
Thanks, lgtm
3 years, 9 months ago (2017-03-09 15:35:54 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:58:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6747fd8bad7c49ddcf8754d45fa0...

Powered by Google App Engine
This is Rietveld 408576698