Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2739893003: views: make comboboxes request focus when clicked (Closed)

Created:
3 years, 9 months ago by Elly Fong-Jones
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: make comboboxes request focus when clicked They should behave this way on non-Mac, even in Harmony mode. BUG=669778 Review-Url: https://codereview.chromium.org/2739893003 Cr-Commit-Position: refs/heads/master@{#456086} Committed: https://chromium.googlesource.com/chromium/src/+/a0edc14c6fae6412feb1fabdef2d7e3372cd86dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/controls/combobox/combobox.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Elly Fong-Jones
sky: ptal? :)
3 years, 9 months ago (2017-03-08 19:22:26 UTC) #3
sky
LGTM
3 years, 9 months ago (2017-03-08 21:05:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739893003/1
3 years, 9 months ago (2017-03-08 21:11:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/336498)
3 years, 9 months ago (2017-03-08 21:54:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739893003/1
3 years, 9 months ago (2017-03-10 16:32:06 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:21:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0edc14c6fae6412feb1fabdef2d...

Powered by Google App Engine
This is Rietveld 408576698