Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2739893002: Store element reference for event-bases too (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store element reference for event-bases too Rather than using the (obviously "racy") technique of looking up the event-base element again when disconnecting from it, store the reference on connect (sharing storage with the sync-base element since they are mutual exclusive) and use it to disconnect properly. BUG=641437 Review-Url: https://codereview.chromium.org/2739893002 Cr-Commit-Position: refs/heads/master@{#455699} Committed: https://chromium.googlesource.com/chromium/src/+/5e556038ac16e5447b8a89daa293d3d2c4f3a288

Patch Set 1 #

Patch Set 2 : Fix order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 1 3 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
fs
3 years, 9 months ago (2017-03-08 20:03:21 UTC) #8
pdr.
On 2017/03/08 at 20:03:21, fs wrote: > LGTM
3 years, 9 months ago (2017-03-08 20:08:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739893002/20001
3 years, 9 months ago (2017-03-09 08:34:24 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 08:39:01 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e556038ac16e5447b8a89daa293...

Powered by Google App Engine
This is Rietveld 408576698