Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 2739843002: DOM: Fix "" handling in Node.lookupNamespaceURI(). (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: Fix "" handling in Node.lookupNamespaceURI(). "" should be handled as null. https://dom.spec.whatwg.org/#dom-node-lookupnamespaceuri New behavior matches to Firefox, Edge, and the latest DOM standard. This CL fixes four tests in wpt, and removes two obsolete DOM conformance tests which this CL breaks. BUG=699449 Review-Url: https://codereview.chromium.org/2739843002 Cr-Commit-Position: refs/heads/master@{#455490} Committed: https://chromium.googlesource.com/chromium/src/+/3803c1269c408f40f27582052656e22d83d1332d

Patch Set 1 #

Messages

Total messages: 14 (10 generated)
tkent
kochi@, would you review this please?
3 years, 9 months ago (2017-03-08 09:15:07 UTC) #6
kochi
LGTM
3 years, 9 months ago (2017-03-08 16:14:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739843002/1
3 years, 9 months ago (2017-03-08 17:52:06 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 18:04:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3803c1269c408f40f27582052656...

Powered by Google App Engine
This is Rietveld 408576698