Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2739813002: PPC/s390: Make explicit that RelocInfo's target_object is always a HeapObject. (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Make explicit that RelocInfo's target_object is always a HeapObject. Port e1fde26608786bd0764663e0575011d5062db5d2 R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6048 LOG=N Review-Url: https://codereview.chromium.org/2739813002 Cr-Commit-Position: refs/heads/master@{#43676} Committed: https://chromium.googlesource.com/v8/v8/+/efd43f094715f873e5590f6912a621eb7c8f7707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M src/ppc/assembler-ppc-inl.h View 2 chunks +9 lines, -11 lines 0 comments Download
M src/s390/assembler-s390-inl.h View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-08 04:33:22 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-08 15:00:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739813002/1
3 years, 9 months ago (2017-03-08 15:15:47 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 15:42:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/efd43f094715f873e5590f6912a621eb7c8...

Powered by Google App Engine
This is Rietveld 408576698