MacViews/a11y: Typedef gfx::NativeViewAccessible to id for all of Mac & iOS.

MacViews/a11y: Typedef gfx::NativeViewAccessible to id for all of Mac & iOS.

Currently on Mac and iOS, gfx::NativeViewAccessible is 'typedef'ed to void*
or id depending on whether the file it's used in is an Objective C file or not
(i.e. if __OBJC__ is defined or not). Previously, when it was only ever used as
a return type on these platforms, this was fine. But in order to implement
AXPlatformNode::FromNativeViewAccessible() on Mac where
gfx::NativeViewAccessible is used as an method argument, this no longer works --
.cc and .mm files see different method signatures, and linking these together
fails (since the .mm file will declare an overload that doesn't exist).

To fix, typedef gfx::NativeViewAccessible to id.

BUG=610589
Review-Url: https://codereview.chromium.org/2739783002
Cr-Commit-Position: refs/heads/master@{#456594}
Committed: https://chromium.googlesource.com/chromium/src/+/df7b70bca50665b8ea628e8012aa1a49c63bd001

[Patti Lor, 2017-03-08 02:18:21]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 02:19:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:21:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-03-10 03:02:29]

patricialor@chromium.org changed reviewers:
+ tapted@chromium.org

[Patti Lor, 2017-03-10 03:02:30]

Thanks Trent :)

[tapted, 2017-03-10 03:55:05]

lgtm with the following (pretty sure it will work!)

Thanks

https://codereview.chromium.org/2739783002/diff/1/testing/platform_test.h
File testing/platform_test.h (right):

https://codereview.chromium.org/2739783002/diff/1/testing/platform_test.h#new...
testing/platform_test.h:12: typedef struct objc_object* id;
hm. I think we can just #include <objc/objc.h> (i.e. remove the #ifndef/#endif).

[Patti Lor, 2017-03-10 04:39:43]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 04:39:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-03-10 05:42:02]

patricialor@chromium.org changed reviewers:
+ thakis@chromium.org

[Patti Lor, 2017-03-10 05:42:03]

Hi thakis@ - PTAL. Thanks!

https://codereview.chromium.org/2739783002/diff/1/testing/platform_test.h
File testing/platform_test.h (right):

https://codereview.chromium.org/2739783002/diff/1/testing/platform_test.h#new...
testing/platform_test.h:12: typedef struct objc_object* id;
On 2017/03/10 03:55:05, tapted wrote:
> hm. I think we can just #include <objc/objc.h> (i.e. remove the
#ifndef/#endif).

Done.

[commit-bot: I haz the power, 2017-03-10 05:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 05:56:10]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-03-10 16:30:23]

lgtm

[Patti Lor, 2017-03-12 23:57:23]

patricialor@chromium.org changed reviewers:
+ dpranke@chromium.org

[Patti Lor, 2017-03-12 23:57:24]

Thanks for the review! dpranke@, PTAL for testing/?

[Dirk Pranke, 2017-03-13 21:17:05]

lgtm

[Patti Lor, 2017-03-14 01:47:25]

The CQ bit was checked by patricialor@chromium.org

[Patti Lor, 2017-03-14 01:47:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2739783002/#ps20001
(title: "Review comments.")

[commit-bot: I haz the power, 2017-03-14 01:48:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:51:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489456045621660,
"parent_rev": "cbfd946ad2caabadb622fe3ad40ecff26cf2dbee", "commit_rev":
"df7b70bca50665b8ea628e8012aa1a49c63bd001"}

[commit-bot: I haz the power, 2017-03-14 02:52:11]

Description was changed from

==========
MacViews/a11y: Typedef gfx::NativeViewAccessible to id for all of Mac & iOS.

Currently on Mac and iOS, gfx::NativeViewAccessible is 'typedef'ed to void*
or id depending on whether the file it's used in is an Objective C file or not
(i.e. if __OBJC__ is defined or not). Previously, when it was only ever used as
a return type on these platforms, this was fine. But in order to implement
AXPlatformNode::FromNativeViewAccessible() on Mac where
gfx::NativeViewAccessible is used as an method argument, this no longer works --
.cc and .mm files see different method signatures, and linking these together
fails (since the .mm file will declare an overload that doesn't exist).

To fix, typedef gfx::NativeViewAccessible to id.

BUG=610589
==========

to

==========
MacViews/a11y: Typedef gfx::NativeViewAccessible to id for all of Mac & iOS.

Currently on Mac and iOS, gfx::NativeViewAccessible is 'typedef'ed to void*
or id depending on whether the file it's used in is an Objective C file or not
(i.e. if __OBJC__ is defined or not). Previously, when it was only ever used as
a return type on these platforms, this was fine. But in order to implement
AXPlatformNode::FromNativeViewAccessible() on Mac where
gfx::NativeViewAccessible is used as an method argument, this no longer works --
.cc and .mm files see different method signatures, and linking these together
fails (since the .mm file will declare an overload that doesn't exist).

To fix, typedef gfx::NativeViewAccessible to id.

BUG=610589

Review-Url: https://codereview.chromium.org/2739783002
Cr-Commit-Position: refs/heads/master@{#456594}
Committed:
https://chromium.googlesource.com/chromium/src/+/df7b70bca50665b8ea628e8012aa...
==========

[commit-bot: I haz the power, 2017-03-14 02:52:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df7b70bca50665b8ea628e8012aa...