Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2739763003: Moves maintaining ShellObservers back to Shell (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
msw, reveman
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, awdf+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, derat+watch_chromium.org, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org, kalyank, mlamouri+watch-notifications_chromium.org, mlamouri+watch-screen-orientation_chromium.org, oka+watchvk_chromium.org, oshima+watch_chromium.org, Peter Beverloo, posciak+watch_chromium.org, sadrul, tfarina, yhanada+watchvk_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves maintaining ShellObservers back to Shell BUG=687660 TEST=none R=msw@chromium.org,reveman@chromium.org Review-Url: https://codereview.chromium.org/2739763003 Cr-Commit-Position: refs/heads/master@{#455569} Committed: https://chromium.googlesource.com/chromium/src/+/00c813f8b366562e6af4ace846ebd302cc0e475a

Patch Set 1 #

Total comments: 10

Patch Set 2 : feedback #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -253 lines) Patch
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/common/frame/header_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/shelf/shelf_locking_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/shelf/wm_shelf.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/cast/tray_cast.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/session/logout_confirmation_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/overview/overview_button_tray.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/web_notification/ash_popup_alignment_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/test/test_shelf_delegate.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/common/wallpaper/wallpaper_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/common/wm/dock/docked_window_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/wm/lock_layout_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_controller.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/wm/overview/window_selector_controller.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M ash/common/wm/panels/panel_frame_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/wm/panels/panel_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/wm/screen_dimmer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 4 chunks +0 lines, -47 lines 0 comments Download
M ash/common/wm_shell.cc View 1 2 2 chunks +0 lines, -54 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/shutdown_observer_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/high_contrast/high_contrast_controller.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/shell.h View 1 2 3 chunks +46 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 10 chunks +76 lines, -11 lines 0 comments Download
M ash/system/chromeos/power/tablet_power_button_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/video_activity_notifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/screen_pinning_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/display_rotation_default_handler.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/exo/wm_helper_ash.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
sky
reveman: exo msw: the rest
3 years, 9 months ago (2017-03-08 19:34:45 UTC) #3
msw
lgtm with minor nits and optional renaming ideas. https://codereview.chromium.org/2739763003/diff/1/ash/accelerators/accelerator_interactive_uitest_chromeos.cc File ash/accelerators/accelerator_interactive_uitest_chromeos.cc (right): https://codereview.chromium.org/2739763003/diff/1/ash/accelerators/accelerator_interactive_uitest_chromeos.cc#newcode65 ash/accelerators/accelerator_interactive_uitest_chromeos.cc:65: Shell::GetInstance()->AddShellObserver(this); ...
3 years, 9 months ago (2017-03-08 19:52:23 UTC) #4
sky
https://codereview.chromium.org/2739763003/diff/1/ash/accelerators/accelerator_interactive_uitest_chromeos.cc File ash/accelerators/accelerator_interactive_uitest_chromeos.cc (right): https://codereview.chromium.org/2739763003/diff/1/ash/accelerators/accelerator_interactive_uitest_chromeos.cc#newcode65 ash/accelerators/accelerator_interactive_uitest_chromeos.cc:65: Shell::GetInstance()->AddShellObserver(this); On 2017/03/08 19:52:23, msw wrote: > tangential: wdyt ...
3 years, 9 months ago (2017-03-08 20:26:06 UTC) #6
reveman
components/exo lgtm
3 years, 9 months ago (2017-03-08 20:36:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739763003/40001
3 years, 9 months ago (2017-03-08 21:50:35 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 22:49:40 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/00c813f8b366562e6af4ace846eb...

Powered by Google App Engine
This is Rietveld 408576698