Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3008)

Issue 2739703005: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, extensions-reviews_chromium.org, halliwell+watch_chromium.org, vmpstr+watch_chromium.org, tfarina, lcwu+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, alokp+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (metrics, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=isherman@chromium.org Review-Url: https://codereview.chromium.org/2739703005 Cr-Commit-Position: refs/heads/master@{#455809} Committed: https://chromium.googlesource.com/chromium/src/+/6c3437a6c08a5e4882d5bb6592db12dcdfbc07f6

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 8

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M base/metrics/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/importer/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/browser/metrics/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics_services_manager/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/minidump_uploader/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M testing/variations/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-09 00:29:07 UTC) #2
Ilya Sherman
LGTM % comments. Thanks. https://codereview.chromium.org/2739703005/diff/20001/chrome/browser/importer/OWNERS File chrome/browser/importer/OWNERS (right): https://codereview.chromium.org/2739703005/diff/20001/chrome/browser/importer/OWNERS#newcode4 chrome/browser/importer/OWNERS:4: # COMPONENT: Internals>Network This should ...
3 years, 9 months ago (2017-03-09 00:58:18 UTC) #3
ymzhang1
https://codereview.chromium.org/2739703005/diff/20001/chrome/browser/importer/OWNERS File chrome/browser/importer/OWNERS (right): https://codereview.chromium.org/2739703005/diff/20001/chrome/browser/importer/OWNERS#newcode4 chrome/browser/importer/OWNERS:4: # COMPONENT: Internals>Network On 2017/03/09 00:58:17, Ilya Sherman wrote: ...
3 years, 9 months ago (2017-03-09 18:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739703005/40001
3 years, 9 months ago (2017-03-09 18:06:02 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:46:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6c3437a6c08a5e4882d5bb6592db...

Powered by Google App Engine
This is Rietveld 408576698