components/safe_browsing_db/safe_browsing_prefs_unittest.cc - Issue 2739643003: Make Sber1/2 pref metrics into Nullable Booleans so we can track how often these prefs are unset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/safe_browsing_prefs_unittest.cc

Issue 2739643003: Make Sber1/2 pref metrics into Nullable Booleans so we can track how often these prefs are unset. (Closed)

Patch Set: Fix test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/safe_browsing_prefs_unittest.cc

diff --git a/components/safe_browsing_db/safe_browsing_prefs_unittest.cc b/components/safe_browsing_db/safe_browsing_prefs_unittest.cc

index af38c78edf89ffdfdbcbd0a3e82f0d401c64e405..303f87826a56a507200fa39512ef77ba688ca6e7 100644

--- a/components/safe_browsing_db/safe_browsing_prefs_unittest.cc

+++ b/components/safe_browsing_db/safe_browsing_prefs_unittest.cc

@@ -24,6 +24,10 @@ class SafeBrowsingPrefsTest : public ::testing::Test {

prefs::kSafeBrowsingScoutReportingEnabled, false);

prefs_.registry()->RegisterBooleanPref(

prefs::kSafeBrowsingScoutGroupSelected, false);

+ prefs_.registry()->RegisterBooleanPref(

+ prefs::kSafeBrowsingSawInterstitialExtendedReporting, false);

+ prefs_.registry()->RegisterBooleanPref(

+ prefs::kSafeBrowsingSawInterstitialScoutReporting, false);

ResetExperiments(/*can_show_scout=*/false, /*only_show_scout=*/false);

}